fix: drop redundant array spread in agent tools (SonarCloud)#13
Merged
Conversation
…loud) Object.values() already returns a fresh array, so [...Object.values(x)] is a redundant clone. Use Object.values(x) directly in the two single-module agents (github-pr-label-actions, triage-github-actions) and update the create-agent SOP skill to teach the non-spread form. The jira examples keep the spread — there it concatenates multiple tool modules, which is a legitimate use.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
SonarCloud: Unnecessarily cloning an array.
Object.values()already returns a fresh array, sotools: [...Object.values(x)]clones it for no reason.Change
examples/github-pr-label-actionsandexamples/triage-github-actions:tools: [...Object.values(githubTools)]→tools: Object.values(githubTools)..claude/skills/create-agent/SKILL.md: teach the non-spread form (and note that the spread is still correct when concatenating several tool modules).The
triage-jira-*examples are intentionally left as-is — there the spread concatenates three tool modules ([...Object.values(a), ...Object.values(b), ...]), which is a legitimate use, not a redundant clone.Same fix applied to the vendored copy in aws-powertools/powertools-lambda-dotnet#1229.
Verification
Both affected examples:
tsc --noEmit+flue build --target nodeclean.